Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Net P1] Code review and Test --> thor/block package #1718

Open
claytonneal opened this issue Jan 20, 2025 · 0 comments
Open

[New Net P1] Code review and Test --> thor/block package #1718

claytonneal opened this issue Jan 20, 2025 · 0 comments
Assignees
@saraantole
Milestone
2.0.0-beta (Pre-R...

Comments

@claytonneal
Copy link
Member

  • Code review and comment
  • Agree potential changes
  • Add PRs to make changes and merge
  • Add unit tests (note: unit tests should use mocking so not making http requests)
  • Add doc comments to all classes, methods, types etc
@claytonneal claytonneal added this to the 2.0.0-beta (Pre-Release) milestone Jan 20, 2025
@claytonneal claytonneal changed the title [New Net] Code review and Test --> thor/block package [New Net P1] Code review and Test --> thor/block package Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saraantole saraantole

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta (Pre-Release)
Development

No branches or pull requests
2 participants
@claytonneal @saraantole