Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codebase refactoring #7

Open
5 tasks
nodkz opened this issue Mar 19, 2020 · 2 comments
Open
5 tasks

Codebase refactoring #7

nodkz opened this issue Mar 19, 2020 · 2 comments

Comments

@nodkz
Copy link

nodkz commented Mar 19, 2020

@vasturiano it will be nice if you permit me to refactor your codebase:

  • add typescript as a main language
  • add eslint & prettier
  • rename & split files (one class per file)
  • setup gitlab actions for automatic tests
  • add semantic-release for automation package publishing when changes landed to master branch
@vasturiano
Copy link
Owner

@nodkz thanks. You can always submit a PR if you find that a particular change/refactor is useful to the broader consumers of the lib. That's highly appreciated.

Also keep in mind that the library already offers TypeScript definitions.

@nodkz
Copy link
Author

nodkz commented Mar 19, 2020

Yep, it has. But better to have real code written in ts which ridiculously simplifies library support by static analysis (autocompletion, type check, safer & faster refactoring).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants