Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excel checksum failures #710

Open
ianhbell opened this issue Dec 16, 2024 · 0 comments
Open

Excel checksum failures #710

ianhbell opened this issue Dec 16, 2024 · 0 comments
Milestone

Comments

@ianhbell
Copy link
Contributor

The Excel checksums included in the Excel worksheet as well as in the Catch2 tests have some failures. Some of the failures are just because the models need to be updated, and checksum values updated too. Others require more investigation.

The current (Dec. 16, 2024) error log is:

-------------------------------------------------------------------------------
Check checksum calculations from the Excel spreadsheet
-------------------------------------------------------------------------------
/Users/ihb/Documents/Code/REFPROP-tests/src/XLS.cpp:162
...............................................................................

/Users/ihb/Documents/Code/REFPROP-tests/src/XLS.cpp:152: FAILED:
  CHECK( r.Output[0] == Approx(expected).epsilon(1e-5) )
with expansion:
  99.85436823935792461
  ==
  Approx( 100.11174619999999891 )
with messages:
  unit_system := 2
  in.FluidName := "nitrogen"
  in.InpCode := "Tliq"
  outString := "TCX"
  in.Ninputs := 5
  in.Units := "SI"
  a := 100.0
  b := -99999999.0
  r.herr := "
  "

/Users/ihb/Documents/Code/REFPROP-tests/src/XLS.cpp:152: FAILED:
  CHECK( r.Output[0] == Approx(expected).epsilon(1e-5) )
with expansion:
  22213.98678601257415721
  ==
  Approx( 23643.99395000000004075 )
with messages:
  unit_system := 1
  in.FluidName := "R32;R125|0.3;0.7"
  in.InpCode := "PS"
  outString := "H"
  in.Ninputs := 6
  in.Units := "molar si"
  a := 10.0
  b := 110.0
  r.herr := "
  "

/Users/ihb/Documents/Code/REFPROP-tests/src/XLS.cpp:152: FAILED:
  CHECK( r.Output[0] == Approx(expected).epsilon(1e-5) )
with expansion:
  1.60112716869815008
  ==
  Approx( 1.60040429400000006 )
with messages:
  unit_system := 8
  in.FluidName := "r218;.1;r123;.9"
  in.InpCode := "PH"
  outString := "D"
  in.Ninputs := 6
  in.Units := "cgs"
  a := 7.0
  b := 180.0
  r.herr := "[SETUP warning -117] Mixture data have not been fitted for one or
  more binary pairs in the specified mixture; the mixing parameters have been
  estimated.
  "

/Users/ihb/Documents/Code/REFPROP-tests/src/XLS.cpp:152: FAILED:
  CHECK( r.Output[0] == Approx(expected).epsilon(1e-5) )
with expansion:
  0.03863738153513799
  ==
  Approx( 0.038640617 )
with messages:
  unit_system := 7
  in.FluidName := "methane;40;ethane;60 mass"
  in.InpCode := "TP"
  outString := "QMASS"
  in.Ninputs := 6
  in.Units := "mks"
  a := 200.0
  b := 2814.55090000000018335
  r.herr := "
  "

/Users/ihb/Documents/Code/REFPROP-tests/src/XLS.cpp:152: FAILED:
  CHECK( r.Output[0] == Approx(expected).epsilon(1e-5) )
with expansion:
  0.0500884742429578 == Approx( 0.050092664 )
with messages:
  unit_system := 1
  in.FluidName := "methane;ethane|.4;.6 mass"
  in.InpCode := "TP"
  outString := "QMOLE"
  in.Ninputs := 6
  in.Units := "molar SI"
  a := 200.0
  b := 2.81455089999999997
  r.herr := "
  "

/Users/ihb/Documents/Code/REFPROP-tests/src/XLS.cpp:152: FAILED:
  CHECK( r.Output[0] == Approx(expected).epsilon(1e-5) )
with expansion:
  280.22485530215385552
  ==
  Approx( 280.23379909999999882 )
with messages:
  unit_system := 2
  in.FluidName := "butane;hexane|.25;.75"
  in.InpCode := "TH>"
  outString := "VIS"
  in.Ninputs := 6
  in.Units := "SI"
  a := 300.0
  b := -21.0
  r.herr := "[SETREF warning -28] Cannot apply reference state (DEF) at a
  specified mixture composition when components have different default
  reference states; will apply defaults to each pure component.
  "

/Users/ihb/Documents/Code/REFPROP-tests/src/XLS.cpp:152: FAILED:
  CHECK( r.Output[0] == Approx(expected).epsilon(1e-5) )
with expansion:
  17.85851998662363016
  ==
  Approx( 17.89148313000000101 )
with messages:
  unit_system := 1
  in.FluidName := "carbon dioxide;nitrogen|.5;.5 mass"
  in.InpCode := "TS"
  outString := "TCX"
  in.Ninputs := 6
  in.Units := "molar SI"
  a := 250.0
  b := 230.69999999999998863
  r.herr := "[SETREF warning -28] Cannot apply reference state (DEF) at a
  specified mixture composition when components have different default
  reference states; will apply defaults to each pure component.
  "

/Users/ihb/Documents/Code/REFPROP-tests/src/XLS.cpp:151: FAILED:
  CHECK( r.ierr < 100 )
with expansion:
  238 < 100
with messages:
  unit_system := 5
  in.FluidName := "propane;R125|10;90"
  in.InpCode := "TH>"
  outString := "F(2)"
  in.Ninputs := 6
  in.Units := "E"
  a := -20.0
  b := 72.0
  r.herr := "[THFLSH error 238] No root exists in the liquid phase for the
  input temperature 244.261 K; H = 18816.1 and Hmin = 18980.4 J/mol.
  "

/Users/ihb/Documents/Code/REFPROP-tests/src/XLS.cpp:152: FAILED:
  CHECK( r.Output[0] == Approx(expected).epsilon(1e-5) )
with expansion:
  -9999990.0
  ==
  Approx( 49.71894257999999667 )
with messages:
  unit_system := 5
  in.FluidName := "propane;R125|10;90"
  in.InpCode := "TH>"
  outString := "F(2)"
  in.Ninputs := 6
  in.Units := "E"
  a := -20.0
  b := 72.0
  r.herr := "[THFLSH error 238] No root exists in the liquid phase for the
  input temperature 244.261 K; H = 18816.1 and Hmin = 18980.4 J/mol.
  "

/Users/ihb/Documents/Code/REFPROP-tests/src/XLS.cpp:152: FAILED:
  CHECK( r.Output[0] == Approx(expected).epsilon(1e-5) )
with expansion:
  174.84626164961630934
  ==
  Approx( 0.004968591 )
with messages:
  unit_system := 2
  in.FluidName := "hexane;butane|.6;.4 mass"
  in.InpCode := "DE"
  outString := "P"
  in.Ninputs := 6
  in.Units := "SI"
  a := 600.0
  b := -120.0
  r.herr := "[DEFLSH warning -5] One or more inputs are out of range;
  Temperature above upper limit: T = 597.056 K, Tmax = 589.941 K; Pressure
  above upper limit: P = 174.846 MPa, Pmax = 149.709 MPa.
  "

/Users/ihb/Documents/Code/REFPROP-tests/src/XLS.cpp:152: FAILED:
  CHECK( r.Output[0] == Approx(expected).epsilon(1e-5) )
with expansion:
  32.9038126461962932
  ==
  Approx( 33.24750173999999703 )
with messages:
  unit_system := 2
  in.FluidName := "argon;co2;propane;acetylene|0.8;0.15;0.03;0.02 mass"
  in.InpCode := "TD"
  outString := "vis"
  in.Ninputs := 6
  in.Units := "SI"
  a := 450.0
  b := 200.0
  r.herr := "[SETUP warning -117] Mixture data have not been fitted for one or
  more binary pairs in the specified mixture; the mixing parameters have been
  estimated.
  "

/Users/ihb/Documents/Code/REFPROP-tests/src/XLS.cpp:152: FAILED:
  CHECK( r.Output[0] == Approx(expected).epsilon(1e-5) )
with expansion:
  0.773556413754665
  ==
  Approx( 0.77364522000000002 )
with messages:
  unit_system := 2
  in.FluidName := "argon;co2;propane;acetylene|0.8;0.15;0.03;0.02 mass"
  in.InpCode := "TH<"
  outString := "qmass"
  in.Ninputs := 6
  in.Units := "SI"
  a := 160.0
  b := 55.0
  r.herr := "[SETREF warning -28] Cannot apply reference state (DEF) at a
  specified mixture composition when components have different default
  reference states; will apply defaults to each pure component.
  "

/Users/ihb/Documents/Code/REFPROP-tests/src/XLS.cpp:152: FAILED:
  CHECK( r.Output[0] == Approx(expected).epsilon(1e-5) )
with expansion:
  170.44300033150400964
  ==
  Approx( 246.1166524999999865 )
with messages:
  unit_system := 5
  in.FluidName := "MM;MDM;MD3M|0.8;0.15;0.05"
  in.InpCode := "TH<"
  outString := "P"
  in.Ninputs := 6
  in.Units := "E"
  a := 500.0
  b := 177.0
  r.herr := "[SETUP warning -117] Mixture data have not been fitted for one or
  more binary pairs in the specified mixture; the mixing parameters have been
  estimated.
  "

/Users/ihb/Documents/Code/REFPROP-tests/src/XLS.cpp:152: FAILED:
  CHECK( r.Output[0] == Approx(expected).epsilon(1e-5) )
with expansion:
  27401.24537803834391525
  ==
  Approx( 30566.3880700000008801 )
with messages:
  unit_system := 1
  in.FluidName := "D4;D5;D6|0.8;0.15;0.05"
  in.InpCode := "TD"
  outString := "E"
  in.Ninputs := 6
  in.Units := "molar si"
  a := 500.0
  b := 1.0
  r.herr := "[SETUP warning -117] Mixture data have not been fitted for one or
  more binary pairs in the specified mixture; the mixing parameters have been
  estimated.
  "
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant