Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ortho-para H2 phase calculation #655

Open
GZALAT opened this issue Nov 8, 2022 · 4 comments
Open

ortho-para H2 phase calculation #655

GZALAT opened this issue Nov 8, 2022 · 4 comments
Assignees
Labels

Comments

@GZALAT
Copy link

GZALAT commented Nov 8, 2022

Description

Phase and quality are determined incorrectly for ortho-para Hydrogen mixtures. For some supercritical regions, "Phase" returns "Two-phase" and "QMass" returns a numerical value. This issue is not present for pure paraHydrogen or normal Hydrogen. It also occurrs only when using the Excel wrapper, not in the Refprop GUI.

Steps to Reproduce

  1. Calculate "=REFPROP("Qmass";"OrthoHydrogen;ParaHydrogen|.25;.75";"TP";"SI";70;1.5)" in any MS Excel Cell...

Expected behavior: [What you expect to happen]
Should be "#State is single phase, quality not calculated", not a numerical value

Actual behavior: [What actually happens]
Numerical value is returned.

Versions

REFPROP Version: 10.0 ; file ParaHydrogen.fld adjusted in line 14 to work on common reference point with orthoHydrogen
Operating System and Version: Windows with MS Excel 2013
Access Method: Excel Wrapper

Additional Information

opH2 Phase issue.xlsx

@ianhbell
Copy link
Contributor

ianhbell commented Nov 8, 2022

What does your excel sheet give for Tc and pc? I can't run it on my machine.

@GZALAT
Copy link
Author

GZALAT commented Nov 9, 2022

Below the screenshot - critical properties for the mixture seem ok:
image

@GZALAT
Copy link
Author

GZALAT commented Nov 9, 2022

For normal H2, calculated critical properties are a bit off:
image

@ianhbell
Copy link
Contributor

ianhbell commented Nov 9, 2022

This seems to be a bug, I agree that this doesn't seem right. @EricLemmon can you please look into this?

@ianhbell ianhbell added the bug label Nov 9, 2022
@ianhbell ianhbell transferred this issue from usnistgov/REFPROP-wrappers May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants