Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropper-generated search term incorrect for subgroups when label is changed #531

Open
maryjgoldman opened this issue Mar 11, 2022 · 0 comments

Comments

@maryjgoldman
Copy link
Collaborator

The search term created by the dropper when clicking on a subgroup column is always "true" or "false", even if you have changed the display label. This is a problem because the find samples feature searches on the display label rather than "true" or "false". This means that any search term auto-generated by the dropper on the subgroup column after changing the display label is incorrect. This is especially difficult as the dropper mode was created to help users to easily create filter and search terms and right now it doesn't on the subgroup columns where the label is changed, which is something that is actively encouraged in our tutorials and help docs.

To reproduce 1) make subgroups 2) change display names 3) use dropper to select one of the subgroups --> see that the search term created by the dropper is still "true" or "false" rather than the new display name AND (most importantly) doesn't match any samples. The correct search term is the new display name NOT "true" or "false"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant