Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ESPN MADE CHANGES TO THEIR API #212

Closed
shulman33 opened this issue Sep 10, 2024 · 13 comments
Closed

[Bug] ESPN MADE CHANGES TO THEIR API #212

shulman33 opened this issue Sep 10, 2024 · 13 comments
Assignees
Labels
bug Something isn't working

Comments

@shulman33
Copy link

Description of Issue

It seems that ESPN made major changes to their API and now the report for ESPN does not work anymore. See this reddit post

Fantasy Football Platform

ESPN

@shulman33 shulman33 added the bug Something isn't working label Sep 10, 2024
@nph4
Copy link

nph4 commented Sep 10, 2024

@uberfastman this is at least partially addressed by PR 210

@sameer095k
Copy link

@uberfastman running into this same issue. pulled PR 210 and still seeing

espn_api.requests.espn_requests.ESPNUnknownError: ESPN returned an HTTP 403

not sure what epsn has changed on their side. open to any fixes anyone has for this.

@aaronsewall
Copy link
Contributor

aaronsewall commented Sep 12, 2024

I added a PR which also bumps the dependency espn-api to 0.36.0, which is the first version that uses the new endpoint. See #213

With these two changes I was successfully able to generate a report.

@sameer095k
Copy link

@aaronsewall i get an error after i run the report creation , running this install doesnt do anything for me. and confirmed that requirements.txt has the new espn-api version. not sure why its complaining about "espn"

root - ERROR - MISSING DEPENDENCY: espn. Please run pip install espn and retry the report generation.
2024-09-11 21:54:47,731 - root - ERROR - MISSING 1 DEPENDENCY

@sameer095k
Copy link

was able to work around that error by going into the container and running pip install -r requirements.txt . not sure why its still downloading the old api

5.0.3->-r requirements.txt (line 23)) (0.1.2)
Downloading espn_api-0.36.0-py3-none-any.whl (64 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 64.5/64.5 kB 3.0 MB/s eta 0:00:00
Installing collected packages: espn-api
Attempting uninstall: espn-api
Found existing installation: espn-api 0.33.0
Uninstalling espn-api-0.33.0:
Successfully uninstalled espn-api-0.33.0
Successfully installed espn-api-0.36.0

@brandoncruz3
Copy link

We need the compose.yml file updated to point to a new container image. ghcr.io/uberfastman/fantasy-football-metrics-weekly-report shows the latest image being created 10 months ago.

@sameer095k
Copy link

yup seems like its merged into main branch now. but compose.yml still points to old container, so you have to run pip install -r requirements on the container after its started up.

@99Probl3ms
Copy link

99Probl3ms commented Sep 19, 2024

I'm still getting ERROR - MISSING DEPENDENCY: espn. after running pip install -r requirements.txt any ideas?

Edit: Ran the update in the docker terminal directly and it fixed it

@nph4
Copy link

nph4 commented Sep 19, 2024

@99Probl3ms are you running pip from inside of the docker container?

docker exec -it fantasy-football-metrics-weekly-report-app-1 pip -r requirements.txt or are you running pip -r requirements.txt ? You need to run the command from inside the docker container

Edit: your edit showed up as I was typing my reply. For others that run into it, you need to run the command from inside of the docker container.

@iv1660yg
Copy link

i'm having them same issue, this is being run in inside the docker container through portainer
Screenshot_26-9-2024

@nph4
Copy link

nph4 commented Sep 27, 2024

i'm having them same issue, this is being run in inside the docker container through portainer

From that bash line run pip -r requirements.txt

@iv1660yg
Copy link

that didn't work i had to run pip install --no-cache-dir -r requirements.txt but now its working!

@uberfastman
Copy link
Owner

@shulman33 @nph4 @sameer095k @aaronsewall @brandoncruz3 @99Probl3ms @iv1660yg thank you all for your patience, my apologies for not getting things updated in a timely fashion for this year's NFL season, I normally try to get working on updates in August but this year I just didn't have time. However I've just published #215 (Release v18.0.0), which includes all the necessary version fixes to the ESPN dependencies and the API base URL change. I also deployed a new docker image with this new code, so you shouldn't have to manually install the updated requirements.txt in it any longer.

I'm closing this bug since it should all be sorted now, but please feel free to reopen and/or ask me any questions if you run into additional issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants