From 6f51a8ef6f9afc33accb5be07e7b7dd8b1eef3de Mon Sep 17 00:00:00 2001 From: Isaac Brodsky Date: Wed, 11 Dec 2024 20:19:51 -0800 Subject: [PATCH] remove unused assert option from cmake, docs --- CMakeLists.txt | 6 ------ website/docs/core-library/compilation-options.md | 6 ------ 2 files changed, 12 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index ecaead51d..302336bae 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -55,9 +55,6 @@ option(BUILD_GENERATORS "Build code generation applications." ON) # for afl++ is provided instead. option(ENABLE_LIBFUZZER "Build fuzzers with libFuzzer support." OFF) -option(ENABLE_POLYGON_TO_CELLS_ASSERT "Build additional asserts into the polyfill algorithm for debugging." OFF) -mark_as_advanced(ENABLE_POLYGON_TO_CELLS_ASSERT) - # These options exist for integration with OSS-Fuzz, so that the fuzzer options # can be passed through only to the fuzzer executables but not the H3 library, # since passing those options to the library too may result in too many implementations @@ -353,9 +350,6 @@ function(add_h3_library name h3_alloc_prefix_override) if(ENABLE_COVERAGE) target_compile_definitions(${name} PRIVATE H3_COVERAGE_TEST=1) endif() - if(ENABLE_POLYGON_TO_CELLS_ASSERT) - target_compile_definitions(${name} PRIVATE H3_POLYGON_TO_CELLS_ASSERT=1) - endif() target_compile_definitions(${name} PUBLIC H3_PREFIX=${H3_PREFIX}) target_compile_definitions(${name} PRIVATE BUILDING_H3=1) diff --git a/website/docs/core-library/compilation-options.md b/website/docs/core-library/compilation-options.md index 38ae9f3b0..be1b36cbc 100644 --- a/website/docs/core-library/compilation-options.md +++ b/website/docs/core-library/compilation-options.md @@ -89,12 +89,6 @@ Whether to enable using clang-tidy to lint source files when building. Only invo [Makefile or Ninja CMake generators](https://cmake.org/cmake/help/latest/prop_tgt/LANG_CLANG_TIDY.html) are used. -## ENABLE_POLYGON_TO_CELLS_ASSERT - -Whether to enable additional debugging assertions in the `polygonToCells` functions. These are not compatible -with all tests and are intended for debugging only. It is not recommended to build release versions with -this flag because that configuration is not well tested. - ## H3_ALLOC_PREFIX Used for directing the library to use a [different set of functions for memory management](./custom-alloc).