Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI suggestion] Move nested filter list expansion toggle to the left #3364

Closed
9 tasks done
ThinkChaos opened this issue Sep 4, 2024 · 3 comments
Closed
9 tasks done
Labels
declined declined

Comments

@ThinkChaos
Copy link

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

Hi,

I'm a long time uBO user (thanks for all the work!) and am writing a tiny guide to install and configure it, so I was looking at the settings, doing my best to think like I've never seen it (and using a fresh browser profile).

I think the nested filter list expansion toggle is easy to miss on the right, and not consistent with the top level ones:
image

So I wanted to suggest moving it to the left of the checkbox.
And potentially styling it closer to the top level ones since I assume the color was chosen to make it more noticeable, which moving would address.

A specific URL where the issue occurs.

moz-extension://caba6d4c-ca82-4730-9a3d-e848de56b77f/dashboard.html#3p-filters.html

Steps to Reproduce

N/A

Expected behavior

N/A

Actual behavior

N/A

uBO version

uBlock Origin 1.59.0

Browser name and version

N/A

Operating System and version

N/A

@gorhill gorhill added the declined declined label Sep 4, 2024
@gorhill
Copy link
Member

gorhill commented Sep 4, 2024

Declined. I did try this originally before release the sublists feature, and this causes the checkboxes to not be vertically aligned, hence why the current choice. Adding a space to prevent misalignment is also not a good solution as this waste horizontal space, especially an issue in mobile version of uBO.

@gorhill gorhill closed this as not planned Won't fix, can't repro, duplicate, stale Sep 4, 2024
@garry-ut99

This comment was marked as abuse.

@ThinkChaos
Copy link
Author

I guess the indent could be reduced on smaller screens; and a vertical line added help show the hierarchy, like indent guides in text editors.
But yeah do as you feel is best, not trying to debate this to death, just spitballing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
declined declined
Projects
None yet
Development

No branches or pull requests

3 participants