Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blank ad spaces appear in optimal/complete mode #266

Open
7 tasks done
male514 opened this issue Jan 9, 2025 · 7 comments
Open
7 tasks done

blank ad spaces appear in optimal/complete mode #266

male514 opened this issue Jan 9, 2025 · 7 comments

Comments

@male514
Copy link

male514 commented Jan 9, 2025

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality by using the chat icon in the popup panel.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO Lite in the browser.

I tried to reproduce the issue when...

  • uBO Lite is the only extension.
  • using a new, unmodified browser profile.

Description

image

i use complete as default mode, the ad has been successfully blocked, but the blank element is still there. It only dissappear when i set default filter mode to basic.
I also tried using basic mode just for this web, but the elements still appear.

A specific URL where the issue occurs.

https://kumparan.com/roy-sidharta1538443914804/5-fakta-mengenai-autobahn-jerman-1plh5juvB98/full

Steps to Reproduce

use optimal/complete mode as default extension mode

Expected behavior

no more blank elements are displayed

Actual behavior

all ads element turns into blank elements

uBO Lite version

2025.1.7.268

Browser name and version

Chrome Versi 131.0.6778.205

Operating system and version

Windows 11

@MasterKia
Copy link
Member

Why didn't you answer truthfully?

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality by using the chat icon in the popup panel.

@MasterKia MasterKia closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2025
@MasterKia MasterKia added the invalid This doesn't seem right label Jan 9, 2025
@male514
Copy link
Author

male514 commented Jan 9, 2025

I have tried it using ublock origin in ms edge, and no blank elements are displayed. so I don't think this is a filter list issue

@MasterKia
Copy link
Member

Report any issues with filter lists or broken website functionality by using the chat icon in the popup panel.

@gorhill
Copy link
Member

gorhill commented Jan 10, 2025

Same issue as with uBlockOrigin/uAssets#26758 (comment), redirect rules are not excepted. Excepted redirect rules should be converted to block rules with higher priority than redirect rules. This was the intent but I overlooked that redirect-rule are immediately rejected as not DNR-compatible, while whether they are exceptions should be considered before rejection.

@gorhill gorhill removed the invalid This doesn't seem right label Jan 10, 2025
@gorhill gorhill reopened this Jan 10, 2025
@stephenhawk8054
Copy link
Member

Actually, a problem I see is that somehow the blocking with important doesn't have higher priority than redirect? uBlockOrigin/uAssets#26790 (comment)

@gorhill
Copy link
Member

gorhill commented Jan 10, 2025

Right, that too, I need to investigate.


The important rules are converted but not output to the rulesets.

gorhill added a commit to gorhill/uBlock that referenced this issue Jan 10, 2025
@stephenhawk8054
Copy link
Member

Confirm it works with latest manual build 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants