Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing grid_mask in py102-example2-zernike.py L.120 #1

Open
JulienNGirard opened this issue Jun 28, 2016 · 0 comments
Open

missing grid_mask in py102-example2-zernike.py L.120 #1

JulienNGirard opened this issue Jun 28, 2016 · 0 comments

Comments

@JulienNGirard
Copy link

JulienNGirard commented Jun 28, 2016 •
edited
Loading

If I am not wrong, there is a missing multiplication by grid_mask in L.120 of py102-example2-zernike.py

rec_wf = sum(val * zernikel(i, grid_rho, grid_phi) for (i, val) in enumerate(rec_wf_pow)
should be
rec_wf = sum(val * zernikel(i, grid_rho, grid_phi)*grid_mask for (i, val) in enumerate(rec_wf_pow)

to have a consistent result.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JulienNGirard