Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto generate bindings when libsql-sqlite3 is changed #1039

Open
avinassh opened this issue Feb 16, 2024 · 1 comment
Open

Auto generate bindings when libsql-sqlite3 is changed #1039

avinassh opened this issue Feb 16, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@avinassh
Copy link
Member

Whenever there is a change in libsql-sqlite3, we need to generate the sqlite header files and bindings. These commands to be run:

# this updates libsql-ffi and also libsql-sys
cargo xtask build-bundled 
# this updates bindings required for sqlite3-mc
cargo build --features multiple-ciphers

This is a manual step and easy to miss. It happened in #1027 which was fixed later by #1037

We should automate this, as part of the build process. We should also move multiple-ciphers build within build-bundled, so that there is only one command to run

@avinassh avinassh added the good first issue Good for newcomers label Feb 16, 2024
@olekspickle
Copy link

olekspickle commented Jan 15, 2025

I want to do it, if there are no takers
I'm thinking of build.rs with rerun-if-changed should do the trick, but not sure where is more appropriate (more context in #1028 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants