Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Link OIDN on WIN32? #1000

Open
lxcug opened this issue Jan 7, 2025 · 1 comment
Open

Should Link OIDN on WIN32? #1000

lxcug opened this issue Jan 7, 2025 · 1 comment

Comments

@lxcug
Copy link

lxcug commented Jan 7, 2025

find_package(OpenImageDenoise "${MIN_OpenImageDenoise_VERSION}" QUIET)
target_link_libraries(${TARGET_NAME} PUBLIC
$<$BOOL:${OpenImageDenoise_FOUND}:OpenImageDenoise> # links OpenImageDenoise only if it's found
)

I build the Engine on windows, i succeed to use OIDN with the code above.

BTW, when built on windows using MSVC some specical chars will causes compile erroe, should replace them with Unicode

@turanszkij
Copy link
Owner

For the windows build there is a solution file: WickedEngine.sln and with that the solution will build successfully, there are no problematic special characters as all are unicode. Open Image Denoise is linked by using #pragma comment(lib,"OpenImageDenoise.lib") in the code.

But if you really want to build with Cmake and want to submit pull request for fix, you can do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants