Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several typos in Higher order components documentation #15

Open
gamtiq opened this issue Sep 18, 2018 · 0 comments
Open

Several typos in Higher order components documentation #15

gamtiq opened this issue Sep 18, 2018 · 0 comments

Comments

@gamtiq
Copy link
Contributor

gamtiq commented Sep 18, 2018

It seems there are the following issues in Higher order components documentation.

Example for withRefs contains the following code:

let sectionElement;
const enhance = withRefs(component => ({
    section: el => {
        sectionElement = el;
        return {
            unsubscribe() {
                sectionElement = el;
            }
        };
    }
});

I suppose unsubscribe function should have the following line:

sectionElement = null;

A couple of typos:

When props are given the the component the RECEIVE_PROPS action will be called with the props as its payload.
These are higher-order functions that accept a set of props and return a function handler*:* This allows the handler

Also description of handlersCreators parameter of withHandlers below signature is incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant