Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move attributes, empty macro expansions, and macros expanding to attributes into floating fragments #558

Open
pgoodman opened this issue Jul 3, 2024 · 0 comments
Labels

Comments

@pgoodman
Copy link
Contributor

pgoodman commented Jul 3, 2024

This is a big issue, with the purpose of addressing database bloat in V8 indexes due to the V8_EXPORT macro. In different translation units, this macro expands differently, resulting in the same classes, or class templates, "looking" different to multiplier's AST/code-based deduplication logic. As a result, there can be two or more copies of many classes stored in the database. This has knock-on effects for the methods, especially method templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant