Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect parsing of URLs with brackets (Wikipedia links) #8

Open
laurastephsmith opened this issue Apr 28, 2022 · 4 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@laurastephsmith
Copy link

It didn't quite get this Wikipedia URL right. It's just a URL in the markdown, not formatted as a []() external link. The markdown was like this:
[^1]: Erica (plant) - Wikipedia. Available at: https://en.wikipedia.org/wiki/Erica_(plant) (Accessed: 28 April 2022).
After archiving it ended up like this:
[^1]: Erica (plant) - Wikipedia. Available at: https://en.wikipedia.org/wiki/Erica_ [(Archived)](https://web.archive.org/web/20220428/https://en.wikipedia.org/wiki/Erica_)(plant) (Accessed: 28 April 2022).
The bit of the title in brackets at the end (common in Wikipedia URLs for disambiguation) confused it a bit!

@tomzorz
Copy link
Owner

tomzorz commented Apr 30, 2022

Hmm, interesting. Thanks for reporting - I'll take a look :)

@tomzorz
Copy link
Owner

tomzorz commented Apr 30, 2022

Although now that I think about it... I might even turn archiving off for wikipedia 🤔

@tomzorz tomzorz added the bug Something isn't working label Apr 30, 2022
@tomzorz tomzorz self-assigned this Apr 30, 2022
@laurastephsmith
Copy link
Author

That crossed my mind. I'm on the fence though...

@laurastephsmith
Copy link
Author

Just to let you know it's not just Wikipedia that uses round brackets in URLS:
https://www.rhs.org.uk/plants/68664/i-viola-i-belmont-blue-(c)/details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants