How to use handle_error in MethodRouter properly

[StarWishsama]

I wrote simple Router error handler like this:

Router::new().route(
    "/favicon.svg",
    get_service(ServeFile::new("dashboard/favicon.svg"))
            .handle_error(handle_error),
)

async fn handle_error(err: Error) -> impl IntoResponse {
    return(StatusCode::INTERNAL_SERVER_ERROR, err.to_string())
}

But got error:

error[E0277]: the trait bound `HandleError<Route<_>, fn(std::io::Error) -> impl std::future::Future<Output = (axum::http::StatusCode, std::string::String)> {handle_error}, _>: tower_service::Service<axum::http::Request<_>>` is not satisfied
    --> main.rs:80:31
     |
80   |                 .handle_error(handle_error),
     |                  ------------ ^^^^^^^^^^^^ the trait `tower_service::Service<axum::http::Request<_>>` is not implemented for `HandleError<Route<_>, fn(std::io::Error) -> impl std::future::Future<Output = (axum::http::StatusCode, std::string::String)> {handle_error}, _>`
     |                  |
     |                  required by a bound introduced by this call
     |
     = help: the following other types implement trait `tower_service::Service<Request>`:
               HandleError<S, F, ()>
               HandleError<S, F, (T1, T2)>
               HandleError<S, F, (T1, T2, T3)>
               HandleError<S, F, (T1, T2, T3, T4)>
               HandleError<S, F, (T1, T2, T3, T4, T5)>
               HandleError<S, F, (T1, T2, T3, T4, T5, T6)>
               HandleError<S, F, (T1, T2, T3, T4, T5, T6, T7)>
               HandleError<S, F, (T1, T2, T3, T4, T5, T6, T7, T8)>
             and 9 others
note: required by a bound in `MethodRouter::<S, B, E>::handle_error`
    --> D:\Software\Rust\.cargo\registry\src\github.com-1ecc6299db9ec823\axum-0.6.7\src\routing\method_routing.rs:1054:41
     |
1054 |         HandleError<Route<B, E>, F, T>: Service<Request<B>, Error = Infallible>,
     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `MethodRouter::<S, B, E>::handle_error`

[davidpdrsn]

Are you using tower-http 0.4? If so you don't need to wrap it in get_service and use handle_error at all. See https://github.com/tokio-rs/axum/blob/remove-spa-router/examples/static-file-server/src/main.rs

[StarWishsama]

Just noticed that axum updated tower-http to 0.4. Thanks for your answering ❤
But what if i use axum 0.6.7 with tower-http 0.4, could it works by simply changing it to ServeFile, or need to wait a new release of axum? 🤔

[davidpdrsn]

But what if i use axum 0.6.7 with tower-http 0.4, could it works by simply changing it to ServeFile, or need to wait a new release of axum? 🤔

Yes that's what I said.

Tower-http 0.3 still works as before but 0.4 has changes. Those aren't breaking changes in axum though.

[danloh]

See https://github.com/tokio-rs/axum/blob/remove-spa-router/examples/static-file-server/src/main.rs

The link is broken, 404

[StarWishsama]

See https://github.com/tokio-rs/axum/blob/remove-spa-router/examples/static-file-server/src/main.rs

The link is broken, 404

Apparently it was merged to main branch now.