Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter builds #41

Open
Mher594 opened this issue Mar 19, 2023 · 0 comments
Open

Stricter builds #41

Mher594 opened this issue Mar 19, 2023 · 0 comments
Labels
🔨 enhancement Infrastructure enhancement

Comments

@Mher594
Copy link
Collaborator

Mher594 commented Mar 19, 2023

To ensure high code quality we can use

  1. Stricter compiler warnings.
  2. Fix issues with clang-tidy checks in GitHub actions

For stricter compiler warning we can use something like

target_compile_options(main PRIVATE
  $<$<CXX_COMPILER_ID:MSVC>:/W4 /WX>
  $<$<NOT:$<CXX_COMPILER_ID:MSVC>>:-Wall -Wextra -Wpedantic>
)

As for clang-tidy issue we need to make sure that it runs during build action (at least for Linux builds). Currently in our codebase we have misc-const-correctness warnings but the build is successful for #40 PR

@Mher594 Mher594 added the 🔨 enhancement Infrastructure enhancement label Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 enhancement Infrastructure enhancement
Projects
None yet
Development

No branches or pull requests

1 participant