You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Crispulator could benefit from some refactoring to improve its handling of custom screen designs, particularly for growth screens. The current structure is:
transfect = transfection + growth to bottleneck representation
select = growth, subsample to bottleneck representation, repeat for num_bottlenecks
sequencing
The mixture of growth in with the other steps isn't intuitive and with #60 merged, select doesn't require subsampling every step after grow!. In these cases, num_bottlenecks can now refer to the number of doublings (because now there isn't subsampling, only growth). That's confusing! Additionally, having to bump the bottleneck_representation to prevent the subsampling in select is an ugly workaround.
The better solution would be expose grow!, allow it to handle multiple doublings, and redefine select for growth screens to only refer to the subsampling step.
The text was updated successfully, but these errors were encountered:
Crispulator could benefit from some refactoring to improve its handling of custom screen designs, particularly for growth screens. The current structure is:
transfect
= transfection + growth to bottleneck representationselect
= growth, subsample to bottleneck representation, repeat fornum_bottlenecks
sequencing
The mixture of growth in with the other steps isn't intuitive and with #60 merged,
select
doesn't require subsampling every step aftergrow!
. In these cases,num_bottlenecks
can now refer to the number of doublings (because now there isn't subsampling, only growth). That's confusing! Additionally, having to bump thebottleneck_representation
to prevent the subsampling inselect
is an ugly workaround.The better solution would be expose
grow!
, allow it to handle multiple doublings, and redefineselect
for growth screens to only refer to the subsampling step.The text was updated successfully, but these errors were encountered: