Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: fct_trim() #358

Closed
sebneus opened this issue Nov 14, 2023 · 1 comment
Closed

Feature Request: fct_trim() #358

sebneus opened this issue Nov 14, 2023 · 1 comment

Comments

@sebneus
Copy link

sebneus commented Nov 14, 2023

Hi

I search for a function which trims the factor levels. It should basically work like fct_drop() but not inbetween used levels:

Example:

factor(c("b", "e"), level = c("a", "b", "c", "d", "e", "f" )) |> 
  forcats::fct_drop() |> 
  levels()
#> [1] "b" "e"

factor(c("b", "e"), level = c("a", "b", "c", "d", "e", "f" )) |> 
  forcats::fct_trim() |> 
  levels()
#> [1] "b" "c" "d" "e"

Regards and thank you for the good job!

@hadley
Copy link
Member

hadley commented Oct 21, 2024

Thanks for filing this issue! Unfortunately, I think it's a bit too specialised for forcats: developing good software requires relentless focus, which means that we have to say no to many good ideas. Even though I'm closing this issue, I really appreciate the feedback, and hope you'll continue to contribute in the future 😄

@hadley hadley closed this as completed Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants