Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doctesting on CI #1601

Closed
lgoettgens opened this issue Sep 10, 2024 · 2 comments
Closed

Fix doctesting on CI #1601

lgoettgens opened this issue Sep 10, 2024 · 2 comments

Comments

@lgoettgens
Copy link
Contributor

It seems that doctests are not part of any CI job (at least I could not find it). If this would be available, #1600 would have already been caught in #1588.
@thofma
Copy link
Owner

thofma commented Sep 10, 2024

They are always run on 1.10, see https://github.com/thofma/Hecke.jl/actions/runs/10788562712/job/29919609424#step:6:530. But it seems they do not report an error.

@thofma thofma changed the title Add doctesting to CI Fix doctesting on CI Sep 10, 2024
@thofma
Copy link
Owner

thofma commented Sep 11, 2024

Fixed in #1602

@thofma thofma closed this as completed Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thofma @lgoettgens