Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocalFundamentalClass Serre tests fail randomly #1428

Closed
lgoettgens opened this issue Mar 14, 2024 · 3 comments
Closed

LocalFundamentalClass Serre tests fail randomly #1428

lgoettgens opened this issue Mar 14, 2024 · 3 comments

Comments

@lgoettgens
Copy link
Contributor 

LocalFundamentalClass Serre: Test Failed at /home/runner/.julia/packages/Hecke/1fdag/test/LocalField/neq.jl:57
  Expression: iszero(a) || valuation(a) > 20
Stacktrace:
 [1] macro expansion
   @ ~/.julia/packages/Hecke/1fdag/test/LocalField/neq.jl:57 [inlined]
 [2] macro expansion
   @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1[151](https://github.com/Nemocas/AbstractAlgebra.jl/actions/runs/8281920352/job/22661589864?pr=1636#step:7:152) [inlined]
 [3] top-level scope
   @ ~/.julia/packages/Hecke/1fdag/test/LocalField/neq.jl:45

https://github.com/Nemocas/AbstractAlgebra.jl/actions/runs/8281920352/job/22661589864?pr=1636#step:7:147

I already observed this a few times, but it usually goes away when restarting the job.
@lgoettgens lgoettgens mentioned this issue Apr 12, 2024
Merged
@thofma
Copy link
Owner

thofma commented Sep 17, 2024

Different error, same file:

Error During Test at /home/runner/work/AbstractAlgebra.jl/AbstractAlgebra.jl/oscar-dev/Hecke/test/LocalField/neq.jl:44
  Got exception outside of a @test
  ArgumentError: Unable to solve linear system
  Stacktrace:
    [1] #solve#10
      @ ~/work/AbstractAlgebra.jl/AbstractAlgebra.jl/src/Solve.jl:568 [inlined]
    [2] #solve#9
      @ ~/work/AbstractAlgebra.jl/AbstractAlgebra.jl/src/Solve.jl:563 [inlined]
    [3] artin_schreier_equation(X::Hecke.ArtinSchreierSolveCtx{FqMatrix, Vector{FqFieldElem}}, c::FqFieldElem)
      @ Hecke ~/work/AbstractAlgebra.jl/AbstractAlgebra.jl/oscar-dev/Hecke/src/LocalField/neq.jl:542
    [4] frobenius_equation2(c::Hecke.LocalFieldElem{Hecke.LocalFieldElem{QadicFieldElem, Hecke.EisensteinLocalField}, Hecke.UnramifiedLocalField}, F::PadicField; frobenius::Hecke.MapEvalCtx, start::Nothing)
      @ Hecke ~/work/AbstractAlgebra.jl/AbstractAlgebra.jl/oscar-dev/Hecke/src/LocalField/neq.jl:698
    [5] (::Hecke.var"#5062#5063"{PadicField, Int64, Hecke.LocalField{Hecke.LocalFieldElem{QadicFieldElem, Hecke.EisensteinLocalField}, Hecke.UnramifiedLocalField}})()
      @ Hecke ~/work/AbstractAlgebra.jl/AbstractAlgebra.jl/oscar-dev/Hecke/src/LocalField/neq.jl:649
    [6] with_precision(f::Hecke.var"#5062#5063"{PadicField, Int64, Hecke.LocalField{Hecke.LocalFieldElem{QadicFieldElem, Hecke.EisensteinLocalField}, Hecke.UnramifiedLocalField}}, K::QadicField, n::Int64)
      @ Nemo ~/work/AbstractAlgebra.jl/AbstractAlgebra.jl/oscar-dev/Nemo/src/flint/qadic.jl:969
    [7] setprecision(f::Function, K::QadicField, n::Int64)
      @ Nemo ~/work/AbstractAlgebra.jl/AbstractAlgebra.jl/oscar-dev/Nemo/src/flint/qadic.jl:977
    [8] setprecision(f::Function, K::Hecke.LocalField{QadicFieldElem, Hecke.EisensteinLocalField}, n::Int64) (repeats 2 times)
      @ Hecke ~/work/AbstractAlgebra.jl/AbstractAlgebra.jl/oscar-dev/Hecke/src/LocalField/LocalField.jl:[403](https://github.com/Nemocas/AbstractAlgebra.jl/actions/runs/10892633978/job/30225950066?pr=1785#step:7:404)
    [9] frobenius_equation(c::Hecke.LocalFieldElem{Hecke.LocalFieldElem{QadicFieldElem, Hecke.EisensteinLocalField}, Hecke.UnramifiedLocalField}, F::PadicField; frobenius::Hecke.MapEvalCtx)
      @ Hecke ~/work/AbstractAlgebra.jl/AbstractAlgebra.jl/oscar-dev/Hecke/src/LocalField/neq.jl:620
   [10] local_fundamental_class_serre(mKL::Hecke.LocalFieldMor{PadicField, Hecke.LocalField{QadicFieldElem, Hecke.EisensteinLocalField}, Hecke.MapDataFromPadicField{Hecke.LocalField{QadicFieldElem, Hecke.EisensteinLocalField}}, Hecke.MapDataFromPadicField{Hecke.LocalField{QadicFieldElem, Hecke.EisensteinLocalField}}, PadicFieldElem})
      @ Hecke ~/work/AbstractAlgebra.jl/AbstractAlgebra.jl/oscar-dev/Hecke/src/LocalField/neq.jl:873

(from https://github.com/Nemocas/AbstractAlgebra.jl/actions/runs/10892633978/job/30225950066?pr=1785#step:7:392)

fieker added a commit that referenced this issue Sep 20, 2024
@fieker
Fixes Serre (improves #1428)
f23047d 
Given an element of norm 1, Hilbert 90 assures it can be written as
sigma(x)/x
Generically, this is solves via Lagrage resolvent and randomization.
(frobenius_equation). If this fails, a much slower method is called\that
constructs the element digit-by-digit (frobenius_equation2).
The 1st function has to increase (temporarily) the precision. However
then the norm 1 condition is no longer true... and thus the input for
the second function illegal hence the failure.
thofma pushed a commit that referenced this issue Sep 20, 2024
@fieker
Fixes Serre (improves #1428) (#1617)
d9b7787 
* Fixes Serre (improves #1428)

Given an element of norm 1, Hilbert 90 assures it can be written as
sigma(x)/x
Generically, this is solves via Lagrage resolvent and randomization.
(frobenius_equation). If this fails, a much slower method is called\that
constructs the element digit-by-digit (frobenius_equation2).
The 1st function has to increase (temporarily) the precision. However
then the norm 1 condition is no longer true... and thus the input for
the second function illegal hence the failure.
@lgoettgens lgoettgens mentioned this issue Sep 24, 2024
Merged
@thofma
Copy link
Owner

thofma commented Sep 24, 2024

Just to make sure. This is still not fixed, right @fieker? We saw it again in https://github.com/Nemocas/Nemo.jl/actions/runs/11002348947/job/30549161397?pr=1860, which includes #1617.

fieker added a commit that referenced this issue Sep 25, 2024
@fieker
another precisino issue...
f7cb011 
hopefully
 - the last (famous last words)
 - the "final" fix for #1428
@fieker fieker mentioned this issue Sep 25, 2024
Merged
fieker added a commit that referenced this issue Sep 27, 2024
@fieker
another precisino issue... (#1627)
a024dc6 
hopefully
 - the last (famous last words)
 - the "final" fix for #1428
@lgoettgens
Copy link
Contributor Author

according to @fieker this is fixed by #1627. I will reopen if I see this again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thofma @lgoettgens