From 472f817e28c9b44c7ada99481561e6a76acd1893 Mon Sep 17 00:00:00 2001 From: Claus Fieker Date: Mon, 16 Sep 2024 14:23:01 +0200 Subject: [PATCH] feat: residue fields of orders in global function fields --- src/GenOrd/GenOrd.jl | 2 +- src/GenOrd/Types.jl | 3 +++ src/NumFieldOrd/NfOrd/ResidueField.jl | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/GenOrd/GenOrd.jl b/src/GenOrd/GenOrd.jl index bcda105c8b..9cf13a6790 100644 --- a/src/GenOrd/GenOrd.jl +++ b/src/GenOrd/GenOrd.jl @@ -96,7 +96,7 @@ basis_matrix_inverse(O::GenOrd{S}) where {S} = O.itrans::dense_matrix_type(elem_ # ################################################################################ -function basis(O::GenOrd) +function basis(O::GenOrd; copy::Bool = true) get_attribute!(O, :basis) do if _is_standard(O) return map(O, basis(field(O))) diff --git a/src/GenOrd/Types.jl b/src/GenOrd/Types.jl index a0e5bc7c2e..75ffd49fdb 100644 --- a/src/GenOrd/Types.jl +++ b/src/GenOrd/Types.jl @@ -91,6 +91,9 @@ end gen_two::GenOrdElem princ_gen::GenOrdElem + prim_elem::GenOrdElem + min_poly_prim_elem + basis_in_prim splitting_type::Tuple{Int, Int} #ordered as ramification index, inertia degree diff --git a/src/NumFieldOrd/NfOrd/ResidueField.jl b/src/NumFieldOrd/NfOrd/ResidueField.jl index 0ed470ae27..6bdf78e305 100644 --- a/src/NumFieldOrd/NfOrd/ResidueField.jl +++ b/src/NumFieldOrd/NfOrd/ResidueField.jl @@ -40,7 +40,7 @@ end # Compute the residue field data given the prime P function compute_residue_field_data!(P) p = minimum(P) - if fits(Int, p) + if isa(p, IntegerUnion) && fits(Int, p) smallp = Int(p) A, m = StructureConstantAlgebra(order(P), P, smallp) compute_residue_field_data!(P, m)