-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Enum.swift #230
Comments
I too am encountering this issue. There are some icons that a pro-only. Examples include: fa-text, fa-user-headset, fa-users-class. These icons do not appear to be listed in Font-Awesome/metadata/icons.json file, so when generating updates to Enum.swift, they do not appear. Are there any suggestions how we can specify these icons other than forking the repository and manually adding them by hand to Enum.swift? I would be happy to contribute a pull request if there is an idea on how support should be incorporated into the current design. Thank you! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Ping! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hello. is it possible that this project is no longer being maintained? I'm more than happy to help! |
To update to a new font version, run:
where x.y.z is the font version. Enum.swift is generated by codegen.swift. Please take a look at it. |
@thii, thank you for your response! Completely understand about how to update it from those instructions in the readme. However the question that was asked was:
I have done exactly this for my own forked copy of the project. I was simply wondering what the ongoing strategy was to:
I'm guessing that the answer is to keep a fork and merge any changes from the master repository into my fork over time. Thank you! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@thii how I can update The Enum, i installed Pod through Podfile |
Run ./codegen.swift. |
the Pod files don't contain ./codegen.swift |
Also wondering how to update the enum to include pro symbols |
Edit: Sorry, had to delete my previous comment as I ran into some problems with it. But they are solved, so the following works. I ran into the same issue today and solved it like this. It's very hacky and there is definitely a more elegant way to properly support this in the future. But it works as a workaround for now.
Note: You will not get duotone rendering with this! This is another issue #223 that needs to be solved eventually. We just need to support the duotone style formally, otherwise the enum with generate errors.
Important: You probably should not commit to this repo from your local copy now as this would add some licensed FA Pro files to the public repo. |
In addition to the instructions above here is a gist with the Enum.swift file all update with the pro font https://gist.github.com/valexa/e206ad23c962b184484e1a085b9c5717 |
I already updated in this PR |
I solved it following @ghowen instructions but with a couple of differences: it results the |
You should use |
Hi
How can I update Enum.swift?!
I want to use pro style of fontawesome but one of icons that I want is missed in the
Enum
(fa-text).Could you please help me?
Thanks
The text was updated successfully, but these errors were encountered: