Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for results inconsistent with a competitor's previous times. #107

Open
mckeenicholas opened this issue Jul 17, 2022 · 3 comments

Comments

@mckeenicholas
Copy link
Contributor

Currently, WCA Live gives a warning if a result entered is not consistent with the competitor's other times in the round, however, an average that is consistent, yet obviously incorrect (for example entering someone's Skewb times for 3x3) does not give any such warning.

Two possible solutions I propose, with potential drawbacks listed below:

Check the results being entered against a competitor's historical times in the database, and give a warning if it is not within some deviation of their previous results.

  • While this is the more accurate option, it would place additional load on the WCA servers, and WCA Live having to verify every result against the db.
  • This requires that a competitor has attended a competition to get a "baseline" for results.
  • Competitors improving quickly, or who had a bad average at their last competitions would give unnecessary warnings.

Check if a result breaks NR/CR/WR and display a warning if so.

  • Not as accurate. A result that is incorrect but does not break any record would not be flagged.
@william-herring
Copy link

william-herring commented Oct 8, 2022

Why not warn for both of these instances? I feel that this is an important change considering how many incorrect record entries there seem to be.

@jonatanklosko
Copy link
Member

We could do more checks, but we need to find a balance. We definitely shouldn't introduce an additional back-and-forth to the server for this. Verifying against current regional records is definitely useful, I believe cubecomps used to do that.

@william-herring
Copy link

william-herring commented Oct 22, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants