Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade React to v16 (Fiber) #62

Open
tferreira opened this issue Aug 1, 2017 · 4 comments
Open

Upgrade React to v16 (Fiber) #62

tferreira opened this issue Aug 1, 2017 · 4 comments

Comments

@tferreira
Copy link
Owner

tferreira commented Aug 1, 2017

React 16 is now available for public use in BETA.

Install instructions:

# Yarn
yarn add react@next react-dom@next

We could install it for trying but material-ui is not ready yet for React 16.

@tferreira tferreira changed the title Upgrade React to v16 (Fiber) [WAIT] Upgrade React to v16 (Fiber) Aug 2, 2017
@tferreira
Copy link
Owner Author

There is some issues with the react-tap-event-plugin lib that is used by material-ui.

ERROR in ./~/react-tap-event-plugin/src/injectTapEventPlugin.js
Module not found: Error: Cannot resolve module 'react-dom/lib/EventPluginHub' in /Users/thomas/piggydime/static/node_modules/react-tap-event-plugin/src
 @ ./~/react-tap-event-plugin/src/injectTapEventPlugin.js 23:2-41

ERROR in ./~/react-tap-event-plugin/src/TapEventPlugin.js
Module not found: Error: Cannot resolve module 'react-dom/lib/EventConstants' in /Users/thomas/piggydime/static/node_modules/react-tap-event-plugin/src
 @ ./~/react-tap-event-plugin/src/TapEventPlugin.js 22:21-60

ERROR in ./~/react-tap-event-plugin/src/TapEventPlugin.js
Module not found: Error: Cannot resolve module 'react-dom/lib/EventPluginUtils' in /Users/thomas/piggydime/static/node_modules/react-tap-event-plugin/src
 @ ./~/react-tap-event-plugin/src/TapEventPlugin.js 23:23-64

ERROR in ./~/react-tap-event-plugin/src/TapEventPlugin.js
Module not found: Error: Cannot resolve module 'react-dom/lib/EventPropagators' in /Users/thomas/piggydime/static/node_modules/react-tap-event-plugin/src
 @ ./~/react-tap-event-plugin/src/TapEventPlugin.js 24:23-64

ERROR in ./~/react-tap-event-plugin/src/TapEventPlugin.js
Module not found: Error: Cannot resolve module 'react-dom/lib/SyntheticUIEvent' in /Users/thomas/piggydime/static/node_modules/react-tap-event-plugin/src
 @ ./~/react-tap-event-plugin/src/TapEventPlugin.js 25:23-64

ERROR in ./~/react-tap-event-plugin/src/TapEventPlugin.js
Module not found: Error: Cannot resolve module 'react-dom/lib/ViewportMetrics' in /Users/thomas/piggydime/static/node_modules/react-tap-event-plugin/src
 @ ./~/react-tap-event-plugin/src/TapEventPlugin.js 27:22-62

Currently waiting for a fix. Issue description updated with a link to the issue on the material-ui repository.

@tferreira tferreira changed the title [WAIT] Upgrade React to v16 (Fiber) Upgrade React to v16 (Fiber) Aug 2, 2017
@lostpebble
Copy link

lostpebble commented Aug 3, 2017

Issue fixed with this pull request mui/material-ui#7624.

Currently working fine with my project and React Fiber beta 2.

EDIT: oops, thought this was the material-ui issue tracker and a duplicate issue being created. Anyway, should be able to use material-ui with React Fiber soon 🙂

@tferreira
Copy link
Owner Author

No problem, it's good to have feedback anyways :)

@tferreira
Copy link
Owner Author

The next version of material-ui works with React 16, but some components are still missing (like SelectField).

Also, injectTapEventPlugin() does not work anymore. Putting this issue on standby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants