Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable retry options for file-lock testcontainers-node.lock #887

Closed
GiDW opened this issue Jan 6, 2025 · 1 comment
Closed

Configurable retry options for file-lock testcontainers-node.lock #887

GiDW opened this issue Jan 6, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@GiDW
Copy link
Contributor

GiDW commented Jan 6, 2025

Our current setup in which we use testcontainers consist of jest tests that spin up a container.

This works well however, spinning up a container becomes slower depending on the amount of tests that are started in parallel.

I've tracked it down to the file-lock around testcontainers-node.lock. Tweaking the retry options for proper-lockfile can really speed-up our test suite.

I've made a PR to make the retry options configurable by the user. #886

Would this be something that can be considered adding to testcontainers?

@cristianrgreco cristianrgreco added the enhancement New feature or request label Jan 8, 2025
@cristianrgreco
Copy link
Collaborator

Implemented by #890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants