Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time optimal trajectory has unused variables velocity_scaling_factor and acceleration_scaling_factory #118

Open
Levi-Armstrong opened this issue Sep 22, 2021 · 1 comment

Comments

@Levi-Armstrong
Copy link
Contributor

@mpowelson I just noticed that the two variables are not being used in time_optimal_trajectory_generation.cpp. Do you know how these should be applied?

@mpowelson
Copy link
Contributor

I think the way it was supposed to work is that if you only set one in the composite it will pass it to TimeOptimalTrajectoryGeneration to be handled internally. If you pass one for each MoveInstruction (use_move_profile == true), then it should set the one in TimeOptimalTrajectoryGeneration to 1 and then rescale each segment in the task generator aftewards. This was because it was going to be complicated to apply it on a per segment basis because of the way it resamples the trajectory.

That said, looking at it now it looks like scaling factors inside TimeOptimalTrajectoryGeneration aren't doing anything. So that should probably be fixed. I'm using TOTG, and it works well. I just didn't notice the scaling factors not working because I am setting one for each PlanInstruction (which gets passed through to the MoveInstructions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants