Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow user to define metric port #2

Open
terinjokes opened this issue Sep 7, 2020 · 2 comments
Open

allow user to define metric port #2

terinjokes opened this issue Sep 7, 2020 · 2 comments
Labels
Priority: Medium Status: In Progress Type: Enhancement

Comments

@terinjokes
Copy link
Owner

We should allow the user to define a custom metrics port. At first this should be via the configuration file, but eventually it should be done via an in-game window.
terinjokes added a commit that referenced this issue Sep 8, 2020
@terinjokes
feat: adds UI for exporter configuration
f98073a 
Adds a simple UI window to enable the Prometheus exporter and define
a listening port number. Values set take effect next time map is loaded,
and are shared across all maps.

Fix: #2
@terinjokes
Copy link
Owner Author

terinjokes commented Sep 8, 2020 •
edited
Loading

I've pushed a branch with basic UI for configuring the exporter's enabled state and listening port numbers.

wip UI

@terinjokes
Copy link
Owner Author

terinjokes commented Sep 8, 2020 •
edited
Loading

Next steps here:

  1. Create a class to store the window state and handle pushing down updates.
  2. Look into creating a textbook when the port field is modified (like the ride/shop cost dialog)
  3. Add a simple event emitter to allow the UI to immediately update other components on save (such as switching what port we're listening on)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Medium Status: In Progress Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terinjokes