-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View Key Metrics #528
Comments
Clearly, it's a must have I think. PR are welcome are ! |
Hello, There are a few things I would still like to change myself. F.e. summing up kafka metrics smoother in the API. I am recycling the table list for the cluster view (with just one row). I am not sure if you think this is a good idea though. |
hey @theesen ! Thanks for this ! To be honest, I was thinking about a true homepage with all the metrics (topics / consumer groups / ...) What do you think about that ? |
Yeah, I think that would be better as well. It felt a bit off, not to have a "landing page" for clusters. Do you have a sketch of what you have in mind roughly? I think it would be nice to have a "tiled" view. Each tile being a cluster with the basic metrics summed up. If you click on the metrics it forwards you to the detail page (topics, connectors, etc..). |
mostly for now, I think about a home per cluster (not cross cluster) for the first one (multiple cluster can be a big deal with acls). Each tile is a group of metrics, here is thought about that:
Maybe this metrics can be also on the top of detail page ? What do you think about that ? |
Sounds good to me. I have started to make the adjustments for the backend. Hopefully be done with that by Monday. Before I start adjusting the frontend, write unit tests etc., I think it'd be good if you could evaluate the backend part. Would save me some refactoring later on. |
No worry, there is no emergency ! The backend seems to be good on my side, just avoid the |
I have updated the PR with a initial draft of the backend metrics for the Cluster view.
Hope you like the structure, feedback is very welcome 👍 |
Overall, seems to be good, but take, you will need to have a route for every type of stats. Do you see what I mean ? |
Yup, good point. Will split up the routes for each metric block. |
@dblooman don't want to work on this anymore? |
Moved onto other projects, so no unfortunately |
No problems, which one for my curiosity? |
It would be great to at a glance see the total number of partitions, topics, size of disk used, out of sync replications etc.
The text was updated successfully, but these errors were encountered: