Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Unit Tests #83

Open
taycaldwell opened this issue Nov 17, 2016 · 3 comments
Open

Unit Tests #83

taycaldwell opened this issue Nov 17, 2016 · 3 comments

Comments

@taycaldwell
Copy link
Owner

taycaldwell commented Nov 17, 2016

There are currently some unit tests for sync and async methods included in the project repository.

These existing unit tests should be cleaned up, using mocks where appropriate to keep the tests isolated.

Ideally we would also like to have unit tests for all major API methods in addition to the existing ones.

@taycaldwell
Copy link
Owner Author

  • Note - I currently have majority of the needed unit tests on my local branch. So I will assign this issue to myself, and push up the tests when I get around to cleaning them up.

@Java-PowerGame
Copy link

Java-PowerGame commented Oct 29, 2017

What is "YOUR-API-KEY-HERE" and "tryndamere" plz ?

@taycaldwell
Copy link
Owner Author

taycaldwell commented Oct 30, 2017

Hi @Java-PowerGame,

Please open a new issue for questions unrelated to this specific issue.

To answer your question, "API-KEY-HERE" is a placeholder string that you need to replace with your development API key. A development API key is a unique string generated for you that allows you to make calls to the Riot Games API. To get a key, you will need to register a developer account on the Riot Games API developer portal.

The string "tryndamere" is an example user name for a player in the game. The user name for a player is also known as a "summoner name".

If you have anymore questions. Feel free to reach out to me by email, or open separate issue.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants