Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate CLI package #1340

Open
Tracked by #1269
verytactical opened this issue Jan 14, 2025 · 1 comment
Open
Tracked by #1269

Separate CLI package #1340

verytactical opened this issue Jan 14, 2025 · 1 comment

Comments

@verytactical
Copy link
Contributor

verytactical commented Jan 14, 2025

Issues

  • fs, path or other node-specific modules might be accidentally imported, and browser version would have to mock them. There is already a VirtualFileSystem that should be the only interface to file system.
  • __dirname shouldn't be used outside of *.build.ts and *.spec.ts files. Compiler doesn't have to know where its sources are.

To do

  • Create separate package with compiler internals (@tact-lang/core?)
  • src/vfs/createNodeFileSystem.ts should be left in @tact-lang/compiler.
  • Ensure only posix (/) paths are passed to internals package.
  • Remove @types/node dependency from internals package.
  • Ban __dirname with eslint.
@anton-trunov
Copy link
Member

(@tact-lang/language?)

@tact-lang/core ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants