Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addresses are implemented in a non-obvious way #1119

Open
Gusarich opened this issue Dec 6, 2024 · 0 comments
Open

Addresses are implemented in a non-obvious way #1119

Gusarich opened this issue Dec 6, 2024 · 0 comments
Assignees
@Gusarich
Labels
enhancement New feature or request typechecker
Milestone
v1.6.0

Comments

@Gusarich
Copy link
Member

Gusarich commented Dec 6, 2024

We should rework addresses, because currently the way they work is not intuitive and doesn't fit into how other types work.

Basically, addr_none should be a valid part of Address type and should be checked by devs against addressNone() (and not null). And Address? should mean Maybe Address, where Address also could be addr_none.

Original comment: #986 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gusarich Gusarich

Labels
enhancement New feature or request typechecker
Projects
None yet
Milestone
v1.6.0
Development

No branches or pull requests
1 participant
@Gusarich