Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Request to Sendable #30

Open
nuid64 opened this issue Sep 27, 2023 · 1 comment
Open

Add Request to Sendable #30

nuid64 opened this issue Sep 27, 2023 · 1 comment

Comments

@nuid64
Copy link
Contributor

nuid64 commented Sep 27, 2023

Sendable represents types of DAP messages that can be sent via JSON RPC, so it would be nice if we add Request in here, since dap-rs supports client-side code.

@nuid64
Copy link
Contributor Author

nuid64 commented Sep 27, 2023

The problem is that Sendable derives Serialize by default and Deserialize if client feature is on, and Request does vice versa. Either Request (and thus every other type) must derive 'Serialize' by default or we must include Request variant in client feature, which looks pretty confusing because essentially Request is a sendable message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant