Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokio support #18

Open
nuid64 opened this issue Aug 2, 2023 · 1 comment
Open

Tokio support #18

nuid64 opened this issue Aug 2, 2023 · 1 comment

Comments

@nuid64
Copy link
Contributor

nuid64 commented Aug 2, 2023

I'm enjoying this library. Really nice work. It would be very convenient to use dap-rs in my project. But I faced with a problem of lack of support of tokio library. I can't imagine program which interact with a think like debug adapter synchronously, so this is real problem to me.
As I understand, making Server's BufReader and BufWriter accept AsyncBufRead and AsyncWrite traits implementators, making some functions async, and, maybe, deriving Send on some structures would be enough, but this is just guess at a glance.
I'd be glad to help implementing this.

@sztomi
Copy link
Owner

sztomi commented Aug 3, 2023

Initially I started writing the library with async code. However, I found that it complicates the interface a lot and I thought the performance gains to be irrelevant. Now the interface is vastly simplified so maybe it makes sense to take another stab at it. Maybe a separate async interface could be provided that is optional to use. I still think the complexity might not be worth it, but if you are interested in prototyping it, I'll give it an honest chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants