From 1aacaf124a2b7157705a8eaaaf23995cea6c5ccf Mon Sep 17 00:00:00 2001
From: Craig Cornelius <ccornelius@google.com>
Date: Tue, 26 Nov 2024 17:03:39 -0800
Subject: [PATCH] Add NodeJS 23.3.0 supporting ICU76 (#348)

---
 run_config.json                            | 22 ++++++++++++++++++++++
 testdriver/datasets.py                     |  9 ++++++---
 testgen/generators/datetime_fmt.py         |  3 ++-
 testgen/generators/list_fmt.py             |  3 ++-
 testgen/generators/relativedatetime_fmt.py |  3 ++-
 5 files changed, 34 insertions(+), 6 deletions(-)

diff --git a/run_config.json b/run_config.json
index 0bee7558..35845fba 100644
--- a/run_config.json
+++ b/run_config.json
@@ -128,6 +128,28 @@
       "per_execution": 10000
     }
   },
+  {
+    "prereq": {
+      "name": "nvm 23.3.0, icu76.1",
+      "version": "23.3.0",
+      "command": "nvm install 23.3.0;nvm use 23.3.0 --silent"
+    },
+    "run": {
+      "icu_version": "icu76",
+      "exec": "node",
+      "test_type": [
+        "collation_short",
+        "datetime_fmt",
+        "list_fmt",
+        "number_fmt",
+        "lang_names",
+        "likely_subtags",
+        "rdt_fmt",
+        "plural_rules"
+      ],
+      "per_execution": 10000
+    }
+  },
   {
     "prereq": {
       "name": "nvm 22.9.0, icu75.1",
diff --git a/testdriver/datasets.py b/testdriver/datasets.py
index 21163b6d..8f88896e 100644
--- a/testdriver/datasets.py
+++ b/testdriver/datasets.py
@@ -218,7 +218,8 @@ class ParallelMode(Enum):
   ParallelByLang = 2
 
 class NodeVersion(Enum):
-  Node22 = "22.1.0"
+  Node23 = "23.3.0"
+  Node22 = "22.9.0"
   Node21 = "21.6.0"
   Node19 = "19.7.0"
   Node18_7 = "18.7.0"
@@ -248,7 +249,8 @@ class ICU4XVersion(Enum):
 # TODO: combine the version info
 IcuVersionToExecutorMap = {
     'node': {
-        '75': ["22.1.0"],
+        '76': ["23.3.0"],
+        '75': ["22.9.0"],
         '74': ["21.6.0"],
         '73': ["20.1.0"],
         '72': ['18.14.2'],
@@ -272,7 +274,8 @@ class ICU4XVersion(Enum):
 # What versions of NodeJS use specific ICU versions
 # https://nodejs.org/en/download/releases/
 NodeICUVersionMap = {
-    '22.1.0': '75.1',
+    '23.3.0': '76.1',
+    '22.9.0': '75.1',
     '21.6.0': '74.1',
     '20.1.0': '73.1',
     '18.14.2': '72.1',
diff --git a/testgen/generators/datetime_fmt.py b/testgen/generators/datetime_fmt.py
index 4de0c5fb..6766f1e5 100644
--- a/testgen/generators/datetime_fmt.py
+++ b/testgen/generators/datetime_fmt.py
@@ -122,7 +122,8 @@ def generate_datetime_data_from_cldr(self, dt_json_path, run_limit=-1):
     def process_test_data(self):
         # Use NOde JS to create the .json files
         icu_nvm_versions = {
-            'icu75': '22.1.0',
+            'icu76': '23.3.0',
+            'icu75': '22.9.0',
             'icu74': '21.6.0',
             'icu73': '20.1.0',
             'icu72': '18.14.2',
diff --git a/testgen/generators/list_fmt.py b/testgen/generators/list_fmt.py
index 5d18f691..866259a1 100644
--- a/testgen/generators/list_fmt.py
+++ b/testgen/generators/list_fmt.py
@@ -15,7 +15,8 @@ class ListFmtGenerator(DataGenerator):
     def process_test_data(self):
         # Use Node JS to create the .json files
         icu_nvm_versions = {
-            'icu75': '22.1.0',
+            'icu76': '23.3.0',
+            'icu75': '22.9.0',
             'icu74': '21.6.0',
             'icu73': '20.1.0',
             'icu72': '18.14.2',
diff --git a/testgen/generators/relativedatetime_fmt.py b/testgen/generators/relativedatetime_fmt.py
index 1cc692f0..6755928a 100644
--- a/testgen/generators/relativedatetime_fmt.py
+++ b/testgen/generators/relativedatetime_fmt.py
@@ -15,7 +15,8 @@ class RelativeDateTimeFmtGenerator(DataGenerator):
     def process_test_data(self):
         # Use NOde JS to create the .json files
         icu_nvm_versions = {
-            'icu75': '22.1.0',
+            'icu76': '23.3.0',
+            'icu75': '22.9.0',
             'icu74': '21.6.0',
             'icu73': '20.1.0',
             'icu72': '18.14.2',