Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover _interface_name_to_common_name uncovered branch by writing a test that specifies a non-existant block device #468

Closed
mulkieran opened this issue Feb 8, 2020 · 1 comment · Fixed by #483
Assignees

Comments

@mulkieran
Copy link
Member

mulkieran commented Feb 8, 2020

I believe that this should be quite straightforward.

@mulkieran mulkieran changed the title Cover _interface_name_to_common_name uncovered branch by writing a test that specifies a non-existant blockdevice Cover _interface_name_to_common_name uncovered branch by writing a test that specifies a non-existant block device Feb 8, 2020
@mulkieran
Copy link
Member Author

It turns out that we can not do this, because the CLI currently has no action that specifies a block device once it is added to a pool. So, we'll have to justify the no-cover pragma, instead, by explaining this fact.

Eventually, we may have a stratis-cli command that does specify a blockdev, like one to set the user info, see issue #922, and then we could take the pragma off. But now, we have nothing.

This was referenced Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants