Expiration date is not updated for user with Add New Order

[michaelbeil]

Describe the bug
When you click + Add New Order for an existing user on the Orders page, add an expiration date, the expiration date will be added to the order, but the existing user's expiration date is not updated.

To Reproduce
Steps to reproduce the behavior:

1. Go to the Orders page
2. Click on + Add New Order
3. Add an expiration date, and click Save Order
4. See the expiration date on the order, but if you visit the Edit User screen of the member, the expiration date will not be updated

Expected behavior
The expiration date should be updated on the edit user screen

Isolating the problem:

• I have deactivated other plugins and confirmed this bug occurs when only Paid Memberships Pro plugin is active.
• This bug happens with a default WordPress theme active, or Memberlite.
• I can reproduce this bug consistently using the steps above.

This came up in ticket 496477, and I could replicate.

WordPress Environment

``` Paid Memberships Pro 2.10.5, WordPress 6.2.1, PHP 7.4.30 and 8 ```

[andrewlimaza]

@michaelbeil I think you're referring to the Add Member From Admin Add On, as the default + Add New Order doesn't support membership expiration fields. It only shows the account expiration date (for the card etc).

Here is a screenshot of the default + Add New Order screen in core:

[andrewlimaza]

*Note: Transferred this issue to the Add Member From Admin repo.

[michaelbeil]

you are right, sir. thank you for transferring this issue as its much quicker than closing it in core and creating a new one.

[JarrydLong]

Additional Feedback on this:

Steps to replicate:
A user with no level
Creating an order (fo the user with no level), but not selecting a specific level for them.
Adding it
The cancel email is sent

Not only should the level that is supplied should be preserved, but that a cancel email should not be generated.

The level and expiration date are not saved when an order is manually added.