Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable UCPD Dead Battery Support Again #2576

Closed
klaus-liebler opened this issue Nov 21, 2024 · 1 comment · Fixed by #2607
Closed

Enable UCPD Dead Battery Support Again #2576

klaus-liebler opened this issue Nov 21, 2024 · 1 comment · Fixed by #2607
Labels
enhancement New feature or request
Milestone
2.10.0

Comments

@klaus-liebler
Copy link

Good evening,

my feature request is related to the problem described here:
manuelbl/usb-pd-arduino#20
https://www.mikrocontroller.net/topic/573034#7778987

In short: The Arduino Framework for STM32G431 disables the Dead Battery Support for USB-C PD applications without offering conditional compilation for this. However, at least I need Dead Battery Support in my application. The only way to archive this now is to comment out the particular line in hw_config.c

I would like to have a preprocessor symbol that enables Dead Battery Support (i.e. disables the deactivation).

Thank you, regards
Klaus
@klaus-liebler klaus-liebler added the enhancement New feature or request label Nov 21, 2024
@fpistm
Copy link
Member

fpistm commented Nov 21, 2024

Hi @klaus-liebler
Feel free to provide a PR for this.
Thanks

fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Dec 17, 2024
@fpistm
chore: allow to not disable UCPD dead battery
2ad9ef8 
Closes stm32duino#2576.

Signed-off-by: Frederic Pillon <[email protected]>
@fpistm fpistm added this to the 2.10 milestone Dec 17, 2024
@fpistm fpistm mentioned this issue Dec 17, 2024
Merged
@fpistm fpistm closed this as completed in aa37c03 Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
STM32 core based on ST HAL
Status: Done
Milestone
2.10.0
Development

Successfully merging a pull request may close this issue.

chore: allow to not disable UCPD dead battery fpistm/Arduino_Core_STM32
2 participants
@klaus-liebler @fpistm