New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seeds API follow ups #116

Open

puffo opened this issue Oct 13, 2022 · 0 comments

Contributor

puffo commented Oct 13, 2022 •

edited

Loading

A couple of possible follow ups from the Seeds API PR

Verify mempool processing handles invalid Foreign Ids

Allow invalid seeds through, let them fail when processed and have no effect
We can then follow up with adjusting the filter to be more selective and robust afterwards - especially seeing as using this internally for now and will likely be pretty careful with the json payloads.

Deprecate ArtistProfile

For this PR, I don't think we need to support artist profiles, just artists, where there shouldn't be any foreign keys (and so then we'll probably move stuff like avatarURL and websiteURL up to artist instead of artistProfile maybe after this PR).

Ensure that slug adjustments are preserved for backward-compatibility

Best solution would be to support legacy identifiers/slugs and store them so that legacy urls are preserved

Handle side effects of changing a field

but, for example if we allow the audioURL to be changed after this has occurred, it will not necessarily re-upload the new track nor generate the new ipfsHash.

Ideas:
Investigate in-memory postgres for tests and previews of seed adjustments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment