Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibSourcey does not support modern version of WebRTC, because cricket::VideoCapturer was removed from WebRTC #284

Open
kapulkin opened this issue Apr 25, 2020 · 2 comments

Comments

@kapulkin
Copy link

Building libSourcey with last version of WebRTC on 23.04.2020 leads to errors. Some errors could be simply fixed:

#include "rtc_base/criticalsection.h" -> #include "rtc_base/critical_section.h"
#include "rtc_base/scoped_ref_ptr.h" -> #include "base/memory/scoped_refptr.h"

But there is more complex:
src/webrtc/.../videopacketsource.h relies on cricket::VideoCapturer, which was deprecated and lately removed from WebRTC (see WebRTC developers discussion there: https://bugs.chromium.org/p/webrtc/issues/detail?id=6353)

The videopacketsource.h file references on file, with was removed:
#include "media/base/videocapturer.h"
and class definition inside extend from removed class:
class VideoPacketSource : public cricket::VideoCapturer

Please, rewrite the code with new video classes according to the samples mentioned in the discussion above.

@kapulkin
Copy link
Author

kapulkin commented Apr 25, 2020

There is a commit, were the cricket library was removed: https://chromium.googlesource.com/external/webrtc/+/45c8b8940042bd2574c39920804ade8343cefdba

@kapulkin kapulkin mentioned this issue Apr 25, 2020
@auscaster
Copy link
Member

Hi!

Thanks very much for the PR, lets continue the discussion over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants