We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modmesh::inout::Gmsh
Some long functions, e.g., Gmsh::is_valid_transition() (and more), should be moved outside the class declaration and header file:
Gmsh::is_valid_transition()
bool is_valid_transition(const std::string s) { if (last_fmt_state == FormatState::BEGIN) { return s == "$MeshFormat"; } else if (last_fmt_state == FormatState::META_END || last_fmt_state == FormatState::PYHSICAL_NAME_END) { return s == "$PhysicalNames" || s == "$Nodes"; } else if (last_fmt_state == FormatState::NODE_END) { return s == "$Elements"; } return false; }
(In this specific case, the argument should use a const reference const std::string & s to save a copy.)
const std::string & s
This issue tracks the work to refactor the Gmsh class.
Gmsh
The text was updated successfully, but these errors were encountered:
@meng5113 Do you want to solve this issue? I think it may be suitable for you.
Sorry, something went wrong.
@KHLee529 Are you interested in refactoring the code?
No branches or pull requests
Some long functions, e.g.,
Gmsh::is_valid_transition()
(and more), should be moved outside the class declaration and header file:(In this specific case, the argument should use a const reference
const std::string & s
to save a copy.)This issue tracks the work to refactor the
Gmsh
class.The text was updated successfully, but these errors were encountered: