Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry endpoint #790

Open
jpds opened this issue Jan 8, 2022 · 7 comments
Open

Telemetry endpoint #790

jpds opened this issue Jan 8, 2022 · 7 comments
Milestone

Comments

@jpds
Copy link

jpds commented Jan 8, 2022

What would you like to be added

Prometheus metrics endpoint with some metric examples:

  • Latencies observed of HTTP service requests
  • Number of HTTP requests seen
  • Number of certificates issued
  • Number of challenge types observed
  • Number of errors encountered issuing certs
  • Timestamp for when CAs expire
  • Timestamp for when issued certificates expire
@jpds jpds added enhancement needs triage Waiting for discussion / prioritization by team labels Jan 8, 2022
@dopey
Copy link
Contributor

dopey commented Jan 12, 2022

  • open-telemetry (comment as a reminder)

@dopey
Copy link
Contributor

dopey commented Jan 12, 2022

Hey @jpds, thanks for opening the issue! We agree that step-ca needs a metrics endpoint. A few members on the team mentioned that we might want to implement the metrics in open telemetry format (I believe prometheus can parse that).

We love the idea but unfortunately we don't have time short term to focus on this project. If anyone in the community is interested in contributing, let us know and we'd be happy to have a design discussion. Cheers 🍻

@dopey dopey removed the needs triage Waiting for discussion / prioritization by team label Jan 12, 2022
@dopey dopey changed the title Prometheus metrics Telemetry endpoint Jan 12, 2022
@tashian
Copy link
Contributor

tashian commented Jan 12, 2022

An OpenTelemetry integration could also be a good approach for instrumenting the step client one day, if that's something we would want to reconsider.

@gdbelvin
Copy link
Contributor

Has this been implemented? If so, in what release?

@MCWertGaming
Copy link

Hey, is there any update on this?

@maraino maraino added this to the v1.0.0 milestone May 24, 2023
@dopey
Copy link
Contributor

dopey commented Jun 13, 2023

Hey, apologies for the radio silence. The best update I can give is that this is still on the roadmap, but it's not prioritized.

For context, we have support for this in our product platform and porting support to open source is not a priority at this time. However, priorities change - if this priority changes we will come back here and update.

@hslatman
Copy link
Member

Several of the metrics mentioned in the OP are implemented in #1669 and will be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants