Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fontbakery log level -- change to PASS ? #75

Open
bobh0303 opened this issue Feb 23, 2021 · 0 comments
Open

fontbakery log level -- change to PASS ? #75

bobh0303 opened this issue Feb 23, 2021 · 0 comments
Assignees

Comments

@bobh0303
Copy link
Contributor

In psfrunfbchecks.py#L94:

        hr = HTMLReporter(runner=runner, loglevels = [SKIP])

we hardcode fontbakery's loglevels to SKIP.

There are now some fontbakery tests (especially those in outline.py) that give different PASS messages (some of which are because there were so many warnings generated that the author decided they must be intentional and issued a PASS instead!). Example from outline.py:

        if len(warnings) > FALSE_POSITIVE_CUTOFF:
            # Let's not waste time.
            yield PASS, ("So many Y-coordinates of points were close to"
                         " boundaries that this was probably by design.")
            return

    if warnings:
        ...
    else:
        yield PASS, "Y-coordinates of points fell on appropriate boundaries."

It would be good to provide a way to drop the loglevels to PASS. If we don't want PASS all the time, perhaps tie it to Pysilfont's loglevel, e.g., something like:

        hr = HTMLReporter(runner=runner, loglevels = [PASS if logger.loglevel == 'I' else SKIP])

For that matter, though this is probably overkill, you could map:
I ==> INFO
V ==> PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants