Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: "ar-aeb-Arab-TN" is listed twice in tags property of "aeb-Arab-TN" #15

Closed
mcdurdin opened this issue May 7, 2024 · 2 comments
Closed

bug: "ar-aeb-Arab-TN" is listed twice in tags property of "aeb-Arab-TN" #15

mcdurdin opened this issue May 7, 2024 · 2 comments

Comments

@mcdurdin
Copy link

mcdurdin commented May 7, 2024 

    {
        "full": "aeb-Arab-TN",
        "iana": [ "Tunisian Arabic" ],
        "iso639_3": "aeb",
        "latnnames": [ "Tounsi" ],
        "localname": "تونسي",
        "localnames": [ "تونسي" ],
        "macrolang": "ar",
        "name": "Arabic, Tunisian Spoken",
        "names": [ "Derja", "Tunisian", "Tunisian Arabic", "Tunisian Darija" ],
        "region": "TN",
        "regionname": "Tunisia",
        "regions": [ "BE", "DE", "ES", "FR", "IT", "LY", "NL" ],
        "script": "Arab",
        "sldr": true,
        "tag": "aeb",
        "tags": [ "aeb-Arab", "aeb-TN", "ajt", "ajt-Arab", "ajt-Arab-TN", "ajt-TN", "ar-aeb", "ar-aeb-Arab", "ar-aeb-Arab-TN", "ar-aeb-TN", "aeb-Arab-IL", "ar-aeb-Arab-IL", "ar-aeb-Arab-TN" ],
                                                                                                             ^^^^^^^^^^^^^^^^                                                ^^^^^^^^^^^^^^^^
        "windows": "aeb-Arab"
    },

Emerging from failing tests in keymanapp/keyman#11003
@mcdurdin mcdurdin mentioned this issue May 7, 2024
Merged
@mcdurdin
Copy link
Author

mcdurdin commented May 7, 2024

This is caught with the updated schema in #17 (comment)

ermshiperete added a commit to keymanapp/keyman that referenced this issue May 7, 2024
@ermshiperete
chore(common): Handcrafted langtags.json due to bugs in official ve…
ba20fbe 
…rsion

The `langtags.json` version downloadable from
https://github.com/silnrsi/langtags/ has several duplicated tags due to
the following bugs:
- silnrsi/langtags#15
- silnrsi/langtags#17

This change removes the duplicates from `langtags.json`, and also removes
the `tpo-Zzzz-LA` tag according to the newer `langtags.json` in the
https://github.com/silnrsi/langtags repo. See also
silnrsi/langtags#16.
ermshiperete added a commit to keymanapp/keyman that referenced this issue May 7, 2024
@ermshiperete
chore(common): Handcrafted langtags.json due to bugs in official ve…
15a924e 
…rsion

The `langtags.json` version downloadable from
https://github.com/silnrsi/langtags/ has several duplicated tags due to
the following bugs:
- silnrsi/langtags#15
- silnrsi/langtags#17

This change removes the duplicates from `langtags.json`, and also removes
the `tpo-Zzzz-LA` tag according to the newer `langtags.json` in the
https://github.com/silnrsi/langtags repo. See also
silnrsi/langtags#16.
@mhosken
Copy link
Contributor

mhosken commented May 7, 2024

Fixed. Generally tags should not duplicate. This was a special due to a hack fix added to the code for that tag. But hey that's why we have tests.

@mhosken mhosken closed this as completed May 7, 2024
ermshiperete added a commit to keymanapp/keyman that referenced this issue May 8, 2024
@ermshiperete
chore(common): Handcrafted langtags.json due to bugs in official ve…
46675cd 
…rsion

The `langtags.json` version downloadable from
https://github.com/silnrsi/langtags/ has several duplicated tags due to
silnrsi/langtags#15.

This change removes the duplicates from `langtags.json`, and also removes
the `tpo-Zzzz-LA` tag according to the newer `langtags.json` in the
https://github.com/silnrsi/langtags repo. See also
silnrsi/langtags#16.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcdurdin @mhosken