Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swapper price impact calculation inaccurate #7790

Closed
kaladinlight opened this issue Sep 23, 2024 · 2 comments · Fixed by #7817
Closed

Swapper price impact calculation inaccurate #7790

kaladinlight opened this issue Sep 23, 2024 · 2 comments · Fixed by #7817
Assignees
@0xApotheosis
Labels
bug Something isn't working

Comments

@kaladinlight
Copy link
Contributor

Overview

The displayed price impact is way off on the swapper display

References and additional details

image

Acceptance Criteria

  • Accurate price impact percentage

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response
@kaladinlight kaladinlight added the bug Something isn't working label Sep 23, 2024
@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Sep 23, 2024
@0xean
Copy link
Contributor

0xean commented Sep 23, 2024

Screenshot 2024-09-23 at 6 52 30 PM

  • fix the value here to show the diff between input fiat amount vs output fiat amount and keep the copy as is

@woodenfurniture
Copy link
Member

Left one will be NET send/receive diff percentage
Right one will be unchanged.

@0xApotheosis 0xApotheosis self-assigned this Sep 25, 2024
@0xApotheosis 0xApotheosis moved this from Up next / groomed to In progress in ShapeShift Dashboard Sep 25, 2024
@0xApotheosis 0xApotheosis mentioned this issue Sep 26, 2024
Merged
1 task
@0xApotheosis 0xApotheosis moved this from In progress to In review in ShapeShift Dashboard Sep 26, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in ShapeShift Dashboard Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xApotheosis 0xApotheosis

Labels
bug Something isn't working
Projects
ShapeShift Dashboard
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use actual input output difference shapeshift/web
4 participants
@0xean @kaladinlight @0xApotheosis @woodenfurniture