-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider switching from got to ky #756
Comments
Sure, why not. What comes immediately to my mind when switching HTTP libraries is whether the properly support proxy env variables. That is often causing issues. Do you have experience with that? |
I am going to test it. I switched a package from got to ky and going to monitor it. Proxy settings can be forwarded to the node fetch method as far as I understood it. |
After using my updated package now for a few days, here a short summary:
As the EnvHttpProxyAgent is still experimental I do not think we should use this in this library. Mine is a minor one without widespread usage, but I will have one more look into configuring without this library, but it might take time as I am fine with my current setup and limited time. |
jenkinsci/docker#1971 (comment)
This applies also here. |
https://www.npmjs.com/package/ky
from the
got
readme:i've used ky in a few projects now and it has been solid. would it make sense to switch here?
The text was updated successfully, but these errors were encountered: