Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider switching from got to ky #756

Open
travi opened this issue Aug 2, 2024 · 5 comments
Open

consider switching from got to ky #756

travi opened this issue Aug 2, 2024 · 5 comments
Labels

Comments

@travi
Copy link
Member

travi commented Aug 2, 2024

https://www.npmjs.com/package/ky

from the got readme:

You probably want Ky instead, by the same people. It's smaller, works in the browser too, and is more stable since it's built upon Fetch.

i've used ky in a few projects now and it has been solid. would it make sense to switch here?

@fgreinacher
Copy link
Contributor

Sure, why not.

What comes immediately to my mind when switching HTTP libraries is whether the properly support proxy env variables. That is often causing issues. Do you have experience with that?

@JonasSchubert
Copy link
Contributor

I am going to test it. I switched a package from got to ky and going to monitor it. Proxy settings can be forwarded to the node fetch method as far as I understood it.
Will come back here, once I have tested more.

@JonasSchubert
Copy link
Contributor

JonasSchubert commented Dec 18, 2024

I am going to test it. I switched a package from got to ky and going to monitor it. Proxy settings can be forwarded to the node fetch method as far as I understood it. Will come back here, once I have tested more.

After using my updated package now for a few days, here a short summary:

As the EnvHttpProxyAgent is still experimental I do not think we should use this in this library. Mine is a minor one without widespread usage, but semantic-release should be stable and not use an experimental library.

I will have one more look into configuring without this library, but it might take time as I am fine with my current setup and limited time.

@JonasSchubert
Copy link
Contributor

I am going to test the changes. I have switched a package from got to ky and will monitor the results. As far as I understand, proxy settings can be forwarded to the node-fetch method.

I will update here once I have conducted more tests.

Let me know if you'd like any further tweaks!

jenkinsci/docker#1971 (comment)

Duplicate of #1531

Also, please do not use an LLM to generate content wasting maintainers time. We expect a proper discussion and due diligence in searching existing issues. Additionally, the problem has to be treated on the www.jenkins.io and adding an eventual link in this repository.

This applies also here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants
@travi @fgreinacher @JonasSchubert and others