Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't identify host by IP string in config cache svc #4181

Open
Michal-Leszczynski opened this issue Dec 18, 2024 · 0 comments
Open

Don't identify host by IP string in config cache svc #4181

Michal-Leszczynski opened this issue Dec 18, 2024 · 0 comments
Assignees

Comments

@Michal-Leszczynski
Copy link
Collaborator

As a follow up to #4166, I wanted to use config cache svc in restore svc in order to improve querying node info.

The problem is that config cache svc identifies node by IP string. Apart from the problem that node IP might change over time and we should handle it gracefully, the IP string itself is not a unique representation for given IP, e.g. 2001:db9:200:0:0:0:0:32 equals 2001:0DB9:200::32.

In my case, some tests failed when SM wanted to get node info:

2024-12-17T14:50:42.0601679Z     helper_integration_test.go:206: run backup: upload: 2001:db9:200:0:0:0:0:32: system_distributed_everywhere.cdc_generation_descriptions_v2: check Scylla backup API support: no config for node 2001:db9:200:0:0:0:0:32

This could also create other problems, as unfortunately SM code was written with the assumption that node can be identified by string IP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants