Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Lobby ID from URL #173

Open
nawkht opened this issue Jan 12, 2021 · 7 comments
Open

Hide Lobby ID from URL #173

nawkht opened this issue Jan 12, 2021 · 7 comments
Labels
enhancement improvement of any kind
Milestone

Comments

@nawkht
Copy link

nawkht commented Jan 12, 2021

For streamers, on twitch as an example, if I tried to play with my friends on stream, I should hide the URL with a trick on OBS so people watching the stream can't see the Lobby ID in the URL and flood the room/server.
Skribbl as an example have a box that you hover over it and then copy the invite link for you friends.
After joining the room, there is nothing showing on the top of the URL.
Adding something like this would be useful.
Thanks.

@Bios-Marcel
Copy link
Member

Bios-Marcel commented Jan 12, 2021

This was a design decision, as I wanted having a "browser native" workflow. This way I can just quickly hit Ctrl + L and Ctrl + C and the lobby address is in my clipboard.

Another interesting scenario that doesn't work in skribbl.io, is that you can't hit F5 or Back and Forward again. My mouse for example has a "back" button which I hit by accident sometimes. How do I get back into a public lobby for example? I assume we could solve this with cookies though.

However, I see why this would be useful for a streamer. Would it be enough to be able to do this as a client-side setting? Meaning you'd have to opt-in. Or maybe you have a better idea to approach both of these problems?

@nawkht
Copy link
Author

nawkht commented Jan 12, 2021

Yes true, I remember accidently hitting my MOUSE4 in skribbl.io couple of times and then I wasn't be able to get back to the game.
Hmmm, how about having a password for the lobby ?
Like you see the ( Public Lobby checkbox ) at the main page ?
Maybe if it's not checked, it should be asking for a password.
If someone random saw the link and typed it, he shouldn't be able to play unless he have the right password.
What do you think about that approach ? You think it's doable ?

@Bios-Marcel
Copy link
Member

Bios-Marcel commented Jan 12, 2021

Of course it is doable ^^

Funnily enough there was a password box in the beginning, but I thought it was useless, so I removed it.
Soooo, we'd have private / public + optional password. Should a public lobby still be able to have a password then?
I think it's kind of useless for a public lobby though, since lobbies don't have names. Meaning nobody would be able to look for a specific public lobby and enter the password.

The homepage is getting more and more messy as well, I was thinking that I might have redesign it either way.

@Bios-Marcel Bios-Marcel added the enhancement improvement of any kind label Jan 12, 2021
@nawkht
Copy link
Author

nawkht commented Jan 12, 2021

If it's doesn't take much time, having a password for the public lobby make sense to me in a scenario where a streamer wants his viewers to join, the streamer should tell the audience to look for the server and type the password.
Like i have a few friend streamers, i could host the app for all of us. If one on us decided to play with viewers, he tell the viewers to go on that app and search for "nawkht" lobby and only few lucky people who type the password fast who can join.
But ofc if you only have time for it. Thanks again.

@Bios-Marcel
Copy link
Member

Well, no promises (Didn't work out well for me in the past). We'll see when I get around to do this.

@nawkht
Copy link
Author

nawkht commented Jan 12, 2021

Well, it's not important. You don't have to waste your time on it.
The password thingy should be enough.
And thanks for your time.

@nawkht
Copy link
Author

nawkht commented Jan 12, 2021

This is unrelated, but i think maybe you should add some donation links, i'm pretty sure many people would like to help.
Paypal / Bitcoin and others.

@Bios-Marcel Bios-Marcel added this to the 1.1.0 milestone Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvement of any kind
Projects
None yet
Development

No branches or pull requests

2 participants