Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing imagestreams for Nginx-1.24 #284

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Conversation

phracek
Copy link
Member

@phracek phracek commented Mar 12, 2024

No description provided.

@phracek
Copy link
Member Author

phracek commented Mar 12, 2024

This pull request affects only OpenShift tests so running only them.

[test-openshift]

@zmiklank
Copy link
Contributor

Do you need this to be merged ASAP?
I would like to use imagestream generator for this too, but it may take a while.
If you need this change now, we can merge this, and do the imagestream generator in the future.
WDYT?

Please note, I did not review this yet.

@phracek
Copy link
Member Author

phracek commented Mar 18, 2024

Do you need this to be merged ASAP? I would like to use imagestream generator for this too, but it may take a while. If you need this change now, we can merge this, and do the imagestream generator in the future. WDYT?

Please note, I did not review this yet.

We can use imagestream generator. We should have new imagestreams definitely during the middle of April for sure.

@phracek phracek force-pushed the add_missing_imagestreams_124 branch from dba3bd7 to cda0552 Compare March 25, 2024 10:30
@phracek
Copy link
Member Author

phracek commented Mar 25, 2024

Nightly builds are failing. It would be nice to merge it, even though we will have imagestreams generated by imagestream-generator.

[test-all]

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek phracek force-pushed the add_missing_imagestreams_124 branch from cda0552 to 03eac4e Compare March 25, 2024 12:39
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek phracek force-pushed the add_missing_imagestreams_124 branch from 03eac4e to 1a31344 Compare March 25, 2024 12:43
@phracek
Copy link
Member Author

phracek commented Mar 25, 2024

[test-openshift]

@zmiklank
Copy link
Contributor

[test-all]

@zmiklank
Copy link
Contributor

There is problem with the GitHub Action for checking the imagestreams that I added. I will address that in separate PR. Meanwhile this LGTM.

@phracek phracek merged commit deab1dd into master Mar 26, 2024
20 checks passed
@phracek phracek deleted the add_missing_imagestreams_124 branch March 26, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants