-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement barcode diagram #14
Comments
That’d be great! By all means, submit a PR. I’ll review asap. |
Some months ago I created the program below to plot some barcodes. Maybe it could be useful to be implemented in your program.
|
Looks great! If you'd submit the barcodes portion as a PR, I'd gladly do a code review and incorporate the implementation. Thanks! |
I have no experience with Git, sorry. I have just added the .py file and two images to my git here: |
I'd rather walk you through the process than do it for you. The process is as follows.
|
Oh, interesting. Thanks for your help and explanation. I'll try to do that as soon as possible. |
Yeah! I'm not sure what screenshot unless you mean the code snipped posted above? There'll be a little bit of working getting the interface right, but overall it looks good (I haven't actually tried running it). I imagine this chunk of code will be most of what is needed in the new function:
Once you submit a first PR, I can help by editing the PR directly. |
Good. I meant https://github.com/tmelorc/ripser/blob/master/barcode.png Also, the functions you have cited are the main one. The most difficulty part is to work with the What I did was to change it to save the output to a file and read that file to create the bars. I defined an option For example, the output I need is like
showing ( So, I have to study the output of |
The link to the .png is dead now. The difference is now that the return will be a list of numpy arrays. The index of the list is the dimension and each array is |
I'm working on the file now. I think it is going well. The |
Looks great to start. I think the way infinity bars are handled could be made a little cleaner, but we can play with a few different options there. |
Good, so please, wait a little bit and I think I can do a good starting point. Maybe tomorrow I could make a PR. I am learning with your code. |
So, I think I'm done. Lets see how to improve it. |
Does anybody tested the function to plot barcode I sent? |
I have pushed this a little further with #24 just now. Hopefully something gets accepted. |
A barcode is a graphical representation as a collection of horizontal line
segments in a plane whose horizontal axis corresponds to the parameter and whose
vertical axis represents an (arbitrary) ordering of homology generators. [1]
I'd be happy to contribute my implementation.
[1] Barcodes: The Persistent Topology of Data
The text was updated successfully, but these errors were encountered: